Is it something that will eventually heal on it's own or will it always be like this or worse?
The problems with my shoulder were not the same, but I'll share anyway just in case it helps. I don't know anything about impingement (beyond my quick google scan) or what the surgery would consist of.
Originally I had surgery to tighten up tendons because I was sublocating my shoulder regularly and then had one bad dislocation. The surgery itself helped tremendously and the joint stayed in place after that, but the pain pump they used for after was not FDA approved and slowly destroyed the cartilage in the joint. Had they not used that, then it would have been great, and they don't use that particular one anymore.
Once my cartilage was gone, I was scraping bone on bone every time I moved and they found deep gouges in the bone and the bones were full of water. Basically, my shoulder was a mess. They knew I would need a full replacement, but my little one was only ~6 months at the time, so we wanted to put it off as long as possible. It only got worse. By her first birthday, every movement was extremely painful and I had lost a lot of range of motion. Shortly after the joint froze and I couldn't move my arm at all so they moved up my surgery. I had a full replacement when she was 14 months. Replacement surgery was a beast to recover from, but worth it. I still get pain, but nothing like before. Range of motion is less than a normal shoulder, but it's enough for most daily things.
I hope you find the answers you need. Honestly I'd say if it's something that may heal, give it some time if you can tolerate it. But if it will not, the constant pain is not worth it and I'd do surgery. If I could go back, I would not have waited. They knew it wouldn't get better, I just wanted my youngest old enough I could wean her before surgery. Waiting was not worth it. And to top it off, we didn't end up having to wean when I did have it done!